]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
openvswitch: fix send of uninitialized stack memory in ct limit reply
authorIlya Maximets <i.maximets@ovn.org>
Sun, 4 Apr 2021 17:50:31 +0000 (19:50 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 4 May 2021 14:08:53 +0000 (16:08 +0200)
commite540cc38c40e34f436248b4e09167141cec19540
tree1607a007f80b4d9c0d57cb077ad0d590f7aef776
parent0a50a9f2de3558ef803944d7e4aaedd6a74c9ac4
openvswitch: fix send of uninitialized stack memory in ct limit reply

BugLink: https://bugs.launchpad.net/bugs/1926489
[ Upstream commit 4d51419d49930be2701c2633ae271b350397c3ca ]

'struct ovs_zone_limit' has more members than initialized in
ovs_ct_limit_get_default_limit().  The rest of the memory is a random
kernel stack content that ends up being sent to userspace.

Fix that by using designated initializer that will clear all
non-specified fields.

Fixes: 11efd5cb04a1 ("openvswitch: Support conntrack zone limit")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/openvswitch/conntrack.c