]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
NFC: nfcmrvl: use nfc-device for firmware download
authorJohan Hovold <johan@kernel.org>
Thu, 30 Mar 2017 10:15:38 +0000 (12:15 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Sun, 18 Jun 2017 21:57:59 +0000 (23:57 +0200)
commite5834ac22948169bbd7c45996d8d4905edd20f5e
tree0fd0eedd0e8e5da394b41cbfb7fcb97d4a3f2604
parent0cbe40112f42cf5e008f9127f6cd5952ba3946c7
NFC: nfcmrvl: use nfc-device for firmware download

Use the nfc- rather than phy-device in firmware-management code that
needs a valid struct device.

This specifically fixes a NULL-pointer dereference in
nfcmrvl_fw_dnld_init() during registration when the underlying tty is
one end of a Unix98 pty.

Note that the driver still uses the phy device for any debugging, which
is fine for now.

Fixes: 3194c6870158 ("NFC: nfcmrvl: add firmware download support")
Cc: stable <stable@vger.kernel.org> # 4.4
Cc: Vincent Cuissard <cuissard@marvell.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/nfcmrvl/fw_dnld.c