]> git.proxmox.com Git - mirror_qemu.git/commit
accel/tcg: Add URL of clang bug to comment about our workaround
authorPeter Maydell <peter.maydell@linaro.org>
Fri, 29 Jan 2021 13:03:30 +0000 (13:03 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 11 Feb 2021 11:50:14 +0000 (11:50 +0000)
commite6a41a045c298538d303cd8fe8d7ae29a0c066ad
tree717347b1e60ed8d698fb414d81eff809c0b06967
parent932a8d1f11ccfbf196ee6fb4a5ccdf274b14a78c
accel/tcg: Add URL of clang bug to comment about our workaround

In cpu_exec() we have a longstanding workaround for compilers which
do not correctly implement the part of the sigsetjmp()/siglongjmp()
spec which requires that local variables which are not changed
between the setjmp and the longjmp retain their value.

I recently ran across the upstream clang bug report for this; add a
link to it to the comment describing the workaround, and generally
expand the comment, so that we have a reasonable chance in future of
understanding why it's there and determining when we can remove it,
assuming clang eventually fixes the bug.

Remove the /* buggy compiler */ comments on the #else and #endif:
they don't add anything to understanding and are somewhat misleading
since they're sandwiching the code path for *non*-buggy compilers.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20210129130330.30820-1-peter.maydell@linaro.org
accel/tcg/cpu-exec.c