]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
scsi: scsi_debug: Fix possible name leak in sdebug_add_host_helper()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 12 Nov 2022 13:10:10 +0000 (21:10 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 26 Nov 2022 00:06:13 +0000 (00:06 +0000)
commite6d773f93a49e0eda88a903a2a6542ca83380eb1
tree33ca2d7786fe0b0fd33066601513c4418f00d3ed
parent47b6a122c7b69a876c7ee2fc064a26b09627de9d
scsi: scsi_debug: Fix possible name leak in sdebug_add_host_helper()

Afer commit 1fa5ae857bb1 ("driver core: get rid of struct device's bus_id
string array"), the name of device is allocated dynamically, it needs be
freed when device_register() returns error.

As comment of device_register() says, one should use put_device() to give
up the reference in the error path. Fix this by calling put_device(), then
the name can be freed in kobject_cleanup(), and sdbg_host is freed in
sdebug_release_adapter().

When the device release is not set, it means the device is not initialized.
We can not call put_device() in this case. Use kfree() to free memory.

Fixes: 1fa5ae857bb1 ("driver core: get rid of struct device's bus_id string array")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221112131010.3757845-1-yangyingliang@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_debug.c