]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
soundwire: stream: Fix test for DP prepare complete
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Fri, 18 Jun 2021 14:47:45 +0000 (15:47 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:31:30 +0000 (09:31 +0200)
commite703eff65e0a869241827abc59344726eb239bd7
tree4f01cde348f698fc5605579c840fae724e674251
parent3a9331f3f0d6968a35566b9cf2ba291bbe854ee2
soundwire: stream: Fix test for DP prepare complete

BugLink: https://bugs.launchpad.net/bugs/1938340
[ Upstream commit 3d3e88e336338834086278236d42039f3cde50e1 ]

In sdw_prep_deprep_slave_ports(), after the wait_for_completion()
the DP prepare status register is read. If this indicates that the
port is now prepared, the code should continue with the port setup.
It is irrelevant whether the wait_for_completion() timed out if the
port is now ready.

The previous implementation would always fail if the
wait_for_completion() timed out, even if the port was reporting
successful prepare.

This patch also fixes a minor bug where the return from sdw_read()
was not checked for error - any error code with LSBits clear could
be misinterpreted as a successful port prepare.

Fixes: 79df15b7d37c ("soundwire: Add helpers for ports operations")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210618144745.30629-1-rf@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/soundwire/stream.c