]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
IB/mlx5: Avoid passing an invalid QP type to firmware
authorNoa Osherovich <noaos@mellanox.com>
Sun, 25 Feb 2018 11:39:51 +0000 (13:39 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 28 Feb 2018 19:10:32 +0000 (12:10 -0700)
commite7b169f34403becd3c9fd3b6e46614ab788f2187
tree09109754cba1a79920cf746d0a6571e8db89a47f
parentda343b6d90e11132f1e917d865d88ee35d6e6d00
IB/mlx5: Avoid passing an invalid QP type to firmware

During QP creation, the mlx5 driver translates the QP type to an
internal value which is passed on to FW. There was no check to make
sure that the translated value is valid, and -EINVAL was coerced into
the mailbox command.

Current firmware refuses this as an invalid QP type, but future/past
firmware may do something else.

Fixes: 09a7d9eca1a6c ('{net,IB}/mlx5: QP/XRCD commands via mlx5 ifc')
Reviewed-by: Ilya Lesokhin <ilyal@mellanox.com>
Signed-off-by: Noa Osherovich <noaos@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/qp.c