]> git.proxmox.com Git - mirror_qemu.git/commit
pc_sysfw: Check for qemu_find_file() failure
authorMarkus Armbruster <armbru@redhat.com>
Wed, 5 Dec 2012 14:28:05 +0000 (15:28 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 4 Jan 2013 13:38:04 +0000 (14:38 +0100)
commite7b1d0ea950fc760371c9580ba6b34c912369a38
treef57f57c5a582bb860e0eaf45f79feed62289deba
parent25bbf61e4bacd1e4fa4115ffcf151051b9d6608e
pc_sysfw: Check for qemu_find_file() failure

pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily
creates a drive without a medium.

When pc_system_flash_init() asks for its size, bdrv_getlength() fails
with -ENOMEDIUM, which isn't checked either.  It fails relatively
cleanly only because -ENOMEDIUM isn't a multiple of 4096:

    $ qemu-system-x86_64 -S -vnc :0 -bios nonexistant
    qemu: PC system firmware (pflash) must be a multiple of 0x1000
    [Exit 1 ]

Fix by handling the qemu_find_file() failure.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/pc_sysfw.c