]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: ethernet: ti: cpsw-phy-sel: check bus_find_device() ret value
authorGrygorii Strashko <grygorii.strashko@ti.com>
Tue, 15 May 2018 23:37:25 +0000 (18:37 -0500)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 1 Mar 2019 13:20:43 +0000 (14:20 +0100)
commite7b6797cf5d8bc40c3986b49eb518ddec18cb3a7
treed06a414e187e9bcd95f72ff4fa0de99bcf4ca89e
parent1a4a2c0cc23857f1de5f27e2a957052a5c749a0a
net: ethernet: ti: cpsw-phy-sel: check bus_find_device() ret value

BugLink: http://bugs.launchpad.net/bugs/1815234
[ Upstream commit c6213eb1aee308e67377fd1890d84f7284caf531 ]

This fixes klockworks warnings: Pointer 'dev' returned from call to
function 'bus_find_device' at line 179 may be NULL and will be dereferenced
at line 181.

    cpsw-phy-sel.c:179: 'dev' is assigned the return value from function 'bus_find_device'.
    bus.c:342: 'bus_find_device' explicitly returns a NULL value.
    cpsw-phy-sel.c:181: 'dev' is dereferenced by passing argument 1 to function 'dev_get_drvdata'.
    device.h:1024: 'dev' is passed to function 'dev_get_drvdata'.
    device.h:1026: 'dev' is explicitly dereferenced.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
[nsekhar@ti.com: add an error message, fix return path]
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/ethernet/ti/cpsw-phy-sel.c