]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ext4: fix support for inode sizes > 1024 bytes
authorTheodore Ts'o <tytso@mit.edu>
Thu, 6 Feb 2020 22:35:01 +0000 (17:35 -0500)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 13 Mar 2020 04:31:00 +0000 (00:31 -0400)
commite81de81857ad0fdbca18e090974a0d3a6964a566
tree6599a5a696a7e1127fadc3c6d5141493006e607d
parent9da119de4c0c3caa296257e00dde8f7f21189f4c
ext4: fix support for inode sizes > 1024 bytes

BugLink: https://bugs.launchpad.net/bugs/1867194
commit 4f97a68192bd33b9963b400759cef0ca5963af00 upstream.

A recent commit, 9803387c55f7 ("ext4: validate the
debug_want_extra_isize mount option at parse time"), moved mount-time
checks around.  One of those changes moved the inode size check before
the blocksize variable was set to the blocksize of the file system.
After 9803387c55f7 was set to the minimum allowable blocksize, which
in practice on most systems would be 1024 bytes.  This cuased file
systems with inode sizes larger than 1024 bytes to be rejected with a
message:

EXT4-fs (sdXX): unsupported inode size: 4096

Fixes: 9803387c55f7 ("ext4: validate the debug_want_extra_isize mount option at parse time")
Link: https://lore.kernel.org/r/20200206225252.GA3673@mit.edu
Reported-by: Herbert Poetzl <herbert@13thfloor.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/ext4/super.c