]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
PCI: Use pci_update_current_state() in pci_enable_device_flags()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 8 Jul 2021 13:25:06 +0000 (15:25 +0200)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Tue, 12 Oct 2021 22:31:28 +0000 (16:31 -0600)
commite8bc369378dbf504ef328224b090b3359565476b
tree4283971f1af2e1ffd0a1ca38aacad04f0ad795eb
parent77f7ee5c777c34684b9e15a42f4e4a3bdfed8d73
PCI: Use pci_update_current_state() in pci_enable_device_flags()

BugLink: https://bugs.launchpad.net/bugs/1946802
[ Upstream commit 14858dcc3b3587f4bb5c48e130ee7d68fc2b0a29 ]

Updating the current_state field of struct pci_dev the way it is done
in pci_enable_device_flags() before calling do_pci_enable_device() may
not work.  For example, if the given PCI device depends on an ACPI
power resource whose _STA method initially returns 0 ("off"), but the
config space of the PCI device is accessible and the power state
retrieved from the PCI_PM_CTRL register is D0, the current_state
field in the struct pci_dev representing that device will get out of
sync with the power.state of its ACPI companion object and that will
lead to power management issues going forward.

To avoid such issues, make pci_enable_device_flags() call
pci_update_current_state() which takes ACPI device power management
into account, if present, to retrieve the current power state of the
device.

Link: https://lore.kernel.org/lkml/20210314000439.3138941-1-luzmaximilian@gmail.com/
Reported-by: Maximilian Luz <luzmaximilian@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Maximilian Luz <luzmaximilian@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/pci/pci.c