]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915: Make intel_{mpllb,c10pll}_state_verify() safer
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 14 Apr 2023 19:01:59 +0000 (22:01 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Sat, 15 Apr 2023 09:18:29 +0000 (12:18 +0300)
commite920aabf8348de4160301b029b13d72eae0531d5
tree19c7c3a2b99e0b167006147ffe68a543f6c91d98
parent3b6692357f70498f617ea1b31a0378070a0acf1c
drm/i915: Make intel_{mpllb,c10pll}_state_verify() safer

intel_{mpllb,c10pll}_state_verify() blows up if you call them
for a non-modeset/fastset commit on account of the relevant
connector not being part of the overall atomic state.
Currently the state checker only runs for modeset/fastset
commits, but for testing purposes it is sometimes desirable
to run it for other commits too. Check for modeset/fastset
in intel_{mpllb,c10pll}_state_verify() itself to make this safe.

v2: Give the new intel_c10pll_state_verify() the same treatment
    Add comment to explain why we do this

Reviewed-by: Jani Nikula <jani.nikula@intel.com> #v1
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230414190159.7904-1-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_cx0_phy.c
drivers/gpu/drm/i915/display/intel_snps_phy.c