]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
mnt: release locks on error path in do_loopback
authorAndrey Vagin <avagin@openvz.org>
Tue, 9 Apr 2013 13:33:29 +0000 (17:33 +0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 9 Apr 2013 18:09:50 +0000 (14:09 -0400)
commite9c5d8a562f01b211926d70443378eb14b29a676
tree7cd74c19415b6390b44110ec3fe756deaabd15d3
parentccf932042fa7785832d8989ba1369cd7c7f5d7a1
mnt: release locks on error path in do_loopback

do_loopback calls lock_mount(path) and forget to unlock_mount
if clone_mnt or copy_mnt fails.

[   77.661566] ================================================
[   77.662939] [ BUG: lock held when returning to user space! ]
[   77.664104] 3.9.0-rc5+ #17 Not tainted
[   77.664982] ------------------------------------------------
[   77.666488] mount/514 is leaving the kernel with locks still held!
[   77.668027] 2 locks held by mount/514:
[   77.668817]  #0:  (&sb->s_type->i_mutex_key#7){+.+.+.}, at: [<ffffffff811cca22>] lock_mount+0x32/0xe0
[   77.671755]  #1:  (&namespace_sem){+++++.}, at: [<ffffffff811cca3a>] lock_mount+0x4a/0xe0

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namespace.c