]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ubifs: Add missing iput if do_tmpfile() failed in rename whiteout
authorZhihao Cheng <chengzhihao1@huawei.com>
Mon, 27 Dec 2021 03:22:35 +0000 (11:22 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:19:32 +0000 (15:19 +0200)
commitea191831df27988f036eda7080c89c59f90e4684
treed5dd4e37f79a5c7deaff2cba7bc55c60bb480359
parent8d2ae8c86455b6f86150278f8b022e53062959b3
ubifs: Add missing iput if do_tmpfile() failed in rename whiteout

BugLink: https://bugs.launchpad.net/bugs/1971497
commit 716b4573026bcbfa7b58ed19fe15554bac66b082 upstream.

whiteout inode should be put when do_tmpfile() failed if inode has been
initialized. Otherwise we will get following warning during umount:
  UBIFS error (ubi0:0 pid 1494): ubifs_assert_failed [ubifs]: UBIFS
  assert failed: c->bi.dd_growth == 0, in fs/ubifs/super.c:1930
  VFS: Busy inodes after unmount of ubifs. Self-destruct in 5 seconds.

Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
fs/ubifs/dir.c