]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
parisc: fix expand_stack() conversion
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 30 Jun 2023 06:04:57 +0000 (23:04 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 30 Jun 2023 06:04:57 +0000 (23:04 -0700)
commitea3f8272876f2958463992f6736ab690fde7fa9c
tree3741faf3133379b8d9d8bbb1ec5d2339161da26b
parent1e6d5dea34325df8dc204575cd0726cd5f2b864f
parisc: fix expand_stack() conversion

In commit 8d7071af8907 ("mm: always expand the stack with the mmap write
lock held") I tried to deal with the remaining odd page fault handling
cases.  The oddest one is ia64, which has stacks that grow both up and
down.  And because ia64 was _so_ odd, I asked people to verify the end
result.

But a close second oddity is parisc, which is the only one that has a
main stack growing up (our "CONFIG_STACK_GROWSUP" config option).  But
it looked obvious enough that I didn't worry about it.

I should have worried a bit more.  Not because it was particularly
complex, but because I just used the wrong variable name.

The previous vma isn't called "prev", it's called "prev_vma".  Blush.

Fixes: 8d7071af8907 ("mm: always expand the stack with the mmap write lock held")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/parisc/mm/fault.c