]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: make get_net_ns return error if NET_NS is disabled
authorChangbin Du <changbin.du@gmail.com>
Fri, 11 Jun 2021 14:29:59 +0000 (22:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 12 Jun 2021 20:13:08 +0000 (13:13 -0700)
commitea6932d70e223e02fea3ae20a4feff05d7c1ea9a
treef886b7b8fd31d7f26b9a61377771688cdd856ec0
parent1adb20f0d496b2c61e9aa1f4761b8d71f93d258e
net: make get_net_ns return error if NET_NS is disabled

There is a panic in socket ioctl cmd SIOCGSKNS when NET_NS is not enabled.
The reason is that nsfs tries to access ns->ops but the proc_ns_operations
is not implemented in this case.

[7.670023] Unable to handle kernel NULL pointer dereference at virtual address 00000010
[7.670268] pgd = 32b54000
[7.670544] [00000010] *pgd=00000000
[7.671861] Internal error: Oops: 5 [#1] SMP ARM
[7.672315] Modules linked in:
[7.672918] CPU: 0 PID: 1 Comm: systemd Not tainted 5.13.0-rc3-00375-g6799d4f2da49 #16
[7.673309] Hardware name: Generic DT based system
[7.673642] PC is at nsfs_evict+0x24/0x30
[7.674486] LR is at clear_inode+0x20/0x9c

The same to tun SIOCGSKNS command.

To fix this problem, we make get_net_ns() return -EINVAL when NET_NS is
disabled. Meanwhile move it to right place net/core/net_namespace.c.

Signed-off-by: Changbin Du <changbin.du@gmail.com>
Fixes: c62cce2caee5 ("net: add an ioctl to get a socket network namespace")
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: David Laight <David.Laight@ACULAB.COM>
Cc: Christian Brauner <christian.brauner@ubuntu.com>
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/socket.h
include/net/net_namespace.h
net/core/net_namespace.c
net/socket.c