]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
of: base: Improve argument length mismatch error
authorBaruch Siach <baruch@tkos.co.il>
Thu, 30 Dec 2021 16:31:53 +0000 (18:31 +0200)
committerPaolo Pisati <paolo.pisati@canonical.com>
Fri, 28 Jan 2022 10:03:14 +0000 (11:03 +0100)
commitea6e71bf492cf468a91db152d13ff06ad8757fc5
tree9e4f6f3c346cc5a28a6d73186d929830bf6d6042
parentba5c511af2bb222b33baf1cce08083861c5fa517
of: base: Improve argument length mismatch error

BugLink: https://bugs.launchpad.net/bugs/1959376
commit 5d05b811b5acb92fc581a7b328b36646c86f5ab9 upstream.

The cells_name field of of_phandle_iterator might be NULL. Use the
phandle name instead. With this change instead of:

  OF: /soc/pinctrl@1000000: (null) = 3 found 2

We get:

  OF: /soc/pinctrl@1000000: phandle pinctrl@1000000 needs 3, found 2

Which is a more helpful messages making DT debugging easier.

In this particular example the phandle name looks like duplicate of the
same node name. But note that the first node is the parent node
(it->parent), while the second is the phandle target (it->node). They
happen to be the same in the case that triggered this improvement. See
commit 72cb4c48a46a ("arm64: dts: qcom: ipq6018: Fix gpio-ranges
property").

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/f6a68e0088a552ea9dfd4d8e3b5b586d92594738.1640881913.git.baruch@tkos.co.il
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/of/base.c