]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
mac80211: remove tasklet enable/disable
authorJohannes Berg <johannes@sipsolutions.net>
Fri, 21 Aug 2009 12:44:45 +0000 (14:44 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 28 Aug 2009 18:40:34 +0000 (14:40 -0400)
commitea77f12f2cc0f31168f2e0259e65a22202ac4dc2
tree8ac1288e1680ae2b6093b4fdca978a4ea86f7e21
parent3d54d25515838543e56889aa7e48f40d00719368
mac80211: remove tasklet enable/disable

Due to the way the tasklets work in mac80211 there's
no need to ever disable them.

However, we need to clear the pending packets when
taking down the last interface because otherwise
the tx_pending_tasklet might be queued if the
driver mucks with the queues (which it shouldn't).

I've had a situation occasionally with ar9170 in
which ksoftirq was using 100% CPU time because
a disabled tasklet was scheduled, and I think that
was due to ar9170 receiving a packet while the
tasklet was disabled. That's strange and it really
should not do that for other reasons, but there's
no need to waste that much CPU time over it, it
should just warn instead.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/driver-ops.h
net/mac80211/ieee80211_i.h
net/mac80211/iface.c
net/mac80211/main.c
net/mac80211/rx.c