]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ovl: fix missing revert_creds() on error path
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 23 Mar 2021 13:19:35 +0000 (16:19 +0300)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Mon, 24 May 2021 23:46:17 +0000 (17:46 -0600)
commitea78dbbbe8a510188fed71b78be935ba7c1b242a
tree2d9a13ca0b4807ab1cf5235dcacad78a3178d5a1
parentab68ab83adcedd083737e0565edcd300ba73effd
ovl: fix missing revert_creds() on error path

BugLink: https://bugs.launchpad.net/bugs/1929455
commit 7b279bbfd2b230c7a210ff8f405799c7e46bbf48 upstream.

Smatch complains about missing that the ovl_override_creds() doesn't
have a matching revert_creds() if the dentry is disconnected.  Fix this
by moving the ovl_override_creds() until after the disconnected check.

Fixes: aa3ff3c152ff ("ovl: copy up of disconnected dentries")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
fs/overlayfs/copy_up.c