]> git.proxmox.com Git - mirror_qemu.git/commit
target/loongarch: Add lock when writing timer clear reg
authorXiaojuan Yang <yangxiaojuan@loongson.cn>
Fri, 1 Jul 2022 09:34:05 +0000 (17:34 +0800)
committerRichard Henderson <richard.henderson@linaro.org>
Mon, 4 Jul 2022 05:38:58 +0000 (11:08 +0530)
commiteb1e9ff8bba91674b4321f2b075c55aa8d9948cc
tree734e3a99251e7bb406c794a83f506a4f2bc20b2c
parent4623367697ebb531fce89a10f9c73a820a5ad82a
target/loongarch: Add lock when writing timer clear reg

There is such error info when running linux kernel:
    tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()).
    calling stack:
    #0 in raise () at /lib64/libc.so.6
    #1 in abort () at /lib64/libc.so.6
    #2 in g_assertion_message_expr.cold () at /lib64/libglib-2.0.so.0
    #3 in g_assertion_message_expr () at /lib64/libglib-2.0.so.0
    #4 in tcg_handle_interrupt (cpu=0x632000030800, mask=2) at ../accel/tcg/tcg-accel-ops.c:79
    #5 in cpu_interrupt (cpu=0x632000030800, mask=2) at ../softmmu/cpus.c:248
    #6 in loongarch_cpu_set_irq (opaque=0x632000030800, irq=11, level=0)
       at ../target/loongarch/cpu.c:100
    #7 in helper_csrwr_ticlr (env=0x632000039440, val=1) at ../target/loongarch/csr_helper.c:85
    #8 in code_gen_buffer ()
    #9 in cpu_tb_exec (cpu=0x632000030800, itb=0x7fff946ac280, tb_exit=0x7ffe4fcb6c30)
       at ../accel/tcg/cpu-exec.c:358

Add mutex iothread lock around loongarch_cpu_set_irq in csrwr_ticlr() to
fix the bug.

Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220701093407.2150607-10-yangxiaojuan@loongson.cn>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
target/loongarch/csr_helper.c