]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
clockevents/drivers/cs5535: Improve resilience to spurious interrupts
authorDavid Kozub <zub@linux.fjfi.cvut.cz>
Thu, 19 Oct 2017 20:57:02 +0000 (22:57 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 20 Oct 2017 11:41:52 +0000 (13:41 +0200)
commiteb39a7c0355393c5a8d930f342ad7a6231b552c4
tree40a9da8f936c510f9e3e7712500b57c769953ae6
parent33d930e59a98fa10a0db9f56c7fa2f21a4aef9b9
clockevents/drivers/cs5535: Improve resilience to spurious interrupts

The interrupt handler mfgpt_tick() is not robust versus spurious interrupts
which happen before the clock event device is registered and fully
initialized.

The reason is that the safe guard against spurious interrupts solely checks
for the clockevents shutdown state, but lacks a check for detached
state. If the interrupt hits while the device is in detached state it
passes the safe guard and dereferences the event handler call back which is
NULL.

Add the missing state check.

Fixes: 8f9327cbb6e8 ("clockevents/drivers/cs5535: Migrate to new 'set-state' interface")
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20171020093103.3317F6004D@linux.fjfi.cvut.cz
drivers/clocksource/cs5535-clockevt.c