]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
iio: light: bh1750: Resolve compiler warning and make code more readable
authorKrzysztof Wilczynski <kw@linux.com>
Fri, 13 Sep 2019 20:24:13 +0000 (22:24 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 29 Jan 2020 04:45:21 +0000 (23:45 -0500)
commiteb92f596423ede0c2d455625cb8573c1a3ef3a93
treec68b3eedc24fa77a46a42b7d13148e2efd046fc8
parentb2ffd1f0f6c68b35cc6f46b08b085910a9ae9821
iio: light: bh1750: Resolve compiler warning and make code more readable

BugLink: https://bugs.launchpad.net/bugs/1859712
[ Upstream commit f552fde983d378e7339f9ea74a25f918563bf0d3 ]

Separate the declaration of struct bh1750_chip_info from definition
of bh1750_chip_info_tbl[] in a single statement as it makes the code
hard to read, and with the extra newline it makes it look as if the
bh1750_chip_info_tbl[] had no explicit type.

This change also resolves the following compiler warning about the
unusual position of the static keyword that can be seen when building
with warnings enabled (W=1):

drivers/iio/light/bh1750.c:64:1: warning:
  ‘static’ is not at beginning of declaration [-Wold-style-declaration]

Related to commit 3a11fbb037a1 ("iio: light: add support for ROHM
BH1710/BH1715/BH1721/BH1750/BH1751 ambient light sensors").

Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/iio/light/bh1750.c