]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
riscv: fix flush_tlb_range() end address for flush_tlb_page()
authorPaul Walmsley <paul.walmsley@sifive.com>
Thu, 8 Aug 2019 02:07:34 +0000 (19:07 -0700)
committerPaul Walmsley <paul.walmsley@sifive.com>
Tue, 13 Aug 2019 21:03:52 +0000 (14:03 -0700)
commiteb93685847a9055283d05951c1b205e737f38533
treef39d6b813b5c7fae9a70c7f5cce7176034fe868b
parentd45331b00ddb179e291766617259261c112db872
riscv: fix flush_tlb_range() end address for flush_tlb_page()

The RISC-V kernel implementation of flush_tlb_page() when CONFIG_SMP
is set is wrong.  It passes zero to flush_tlb_range() as the final
address to flush, but it should be at least 'addr'.

Some other Linux architecture ports use the beginning address to
flush, plus PAGE_SIZE, as the final address to flush.  This might
flush slightly more than what's needed, but it seems unlikely that
being more clever would improve anything.  So let's just take that
implementation for now.

While here, convert the macro into a static inline function, primarily
to avoid unintentional multiple evaluations of 'addr'.

This second version of the patch fixes a coding style issue found by
Christoph Hellwig <hch@lst.de>.

Reported-by: Andreas Schwab <schwab@suse.de>
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
arch/riscv/include/asm/tlbflush.h