]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
io_uring/rw: fix unexpected link breakage
authorPavel Begunkov <asml.silence@gmail.com>
Sun, 16 Oct 2022 21:42:58 +0000 (22:42 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 24 Nov 2022 13:25:07 +0000 (14:25 +0100)
commitebe58926d378809e431f3327683006db928c91d8
treee5f173208e4836fbd44c59a6e98ebe71033b1d23
parent3dcc679593d628ac1b0a4f00446afb91dc5b6115
io_uring/rw: fix unexpected link breakage

BugLink: https://bugs.launchpad.net/bugs/1996825
[ upstream commit bf68b5b34311ee57ed40749a1257a30b46127556 ]

req->cqe.res is set in io_read() to the amount of bytes left to be done,
which is used to figure out whether to fail a read or not. However,
io_read() may do another without returning, and we stash the previous
value into ->bytes_done but forget to update cqe.res. Then we ask a read
to do strictly less than cqe.res but expect the return to be exactly
cqe.res.

Fix the bug by updating cqe.res for retries.

Cc: stable@vger.kernel.org
Reported-and-Tested-by: Beld Zhang <beldzhang@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/3a1088440c7be98e5800267af922a67da0ef9f13.1664235732.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
fs/io_uring.c