]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/rockchip: lvds: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 23 May 2018 19:07:16 +0000 (21:07 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Sat, 16 Jun 2018 12:22:35 +0000 (14:22 +0200)
commitebfb081edc8afd250a6d290c37481bfb2262e7cb
treee2e24aa044337b6e83dbb91449cd277cd3b15033
parente89ea355966182007712c396a3b8e78255f17c32
drm/rockchip: lvds: add missing of_node_put

The device node iterators perform an of_node_get on each iteration, so a
jump out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// </smpl>

Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Cc: stable@vger.kernel.org
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/1527102436-13447-6-git-send-email-Julia.Lawall@lip6.fr
drivers/gpu/drm/rockchip/rockchip_lvds.c