]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
USB: cdc-acm: fix unprivileged TIOCCSERIAL
authorJohan Hovold <johan@kernel.org>
Thu, 8 Apr 2021 13:16:01 +0000 (15:16 +0200)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Mon, 24 May 2021 23:46:26 +0000 (17:46 -0600)
commitecc912f1b73465cbcb6b4f30875726e0a9ed9c2e
tree6f75524a99bdf33613241347cd7dff83d8b77336
parent9ab7911dd76fa4e83c13dd6dd92bab2fc9924c4e
USB: cdc-acm: fix unprivileged TIOCCSERIAL

BugLink: https://bugs.launchpad.net/bugs/1929455
[ Upstream commit dd5619582d60007139f0447382d2839f4f9e339b ]

TIOCSSERIAL is a horrid, underspecified, legacy interface which for most
serial devices is only useful for setting the close_delay and
closing_wait parameters.

A non-privileged user has only ever been able to set the since long
deprecated ASYNC_SPD flags and trying to change any other *supported*
feature should result in -EPERM being returned. Setting the current
values for any supported features should return success.

Fix the cdc-acm implementation which instead indicated that the
TIOCSSERIAL ioctl was not even implemented when a non-privileged user
set the current values.

Fixes: ba2d8ce9db0a ("cdc-acm: implement TIOCSSERIAL to avoid blocking close(2)")
Acked-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210408131602.27956-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/usb/class/cdc-acm.c