]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
IMA: remove the dependency on CRYPTO_MD5
authorTHOBY Simon <Simon.THOBY@viveris.fr>
Mon, 16 Aug 2021 08:10:59 +0000 (08:10 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 15 Oct 2021 09:27:39 +0000 (11:27 +0200)
commiteccff62fbb6145058e903e7c101dd4da3ba33869
tree7e6a3f47b8b18b43270b6605b1edab8f56a26355
parent56dc2864e21585b7312d9d4d9d877a38c68eb524
IMA: remove the dependency on CRYPTO_MD5

BugLink: https://bugs.launchpad.net/bugs/1946788
commit 8510505d55e194d3f6c9644c9f9d12c4f6b0395a upstream.

MD5 is a weak digest algorithm that shouldn't be used for cryptographic
operation. It hinders the efficiency of a patch set that aims to limit
the digests allowed for the extended file attribute namely security.ima.
MD5 is no longer a requirement for IMA, nor should it be used there.

The sole place where we still use the MD5 algorithm inside IMA is setting
the ima_hash algorithm to MD5, if the user supplies 'ima_hash=md5'
parameter on the command line.  With commit ab60368ab6a4 ("ima: Fallback
to the builtin hash algorithm"), setting "ima_hash=md5" fails gracefully
when CRYPTO_MD5 is not set:
ima: Can not allocate md5 (reason: -2)
ima: Allocating md5 failed, going to use default hash algorithm sha256

Remove the CRYPTO_MD5 dependency for IMA.

Signed-off-by: THOBY Simon <Simon.THOBY@viveris.fr>
Reviewed-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
[zohar@linux.ibm.com: include commit number in patch description for
stable.]
Cc: stable@vger.kernel.org # 4.17
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
security/integrity/ima/Kconfig