]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
auxdisplay: lcd2s: Use proper API to free the instance of charlcd object
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 23 Feb 2022 15:47:18 +0000 (17:47 +0200)
committerPaolo Pisati <paolo.pisati@canonical.com>
Wed, 9 Mar 2022 14:17:54 +0000 (15:17 +0100)
commitece0fafff7ecc78f2c3194d3868e94e281da6d07
treee82623f5d450bd6685a61b5478cf565efd015828
parent35e6a22e6eee3bb9e0e7f587c6703b4d1f6b6d79
auxdisplay: lcd2s: Use proper API to free the instance of charlcd object

BugLink: https://bugs.launchpad.net/bugs/1964361
commit 9ed331f8a0fb674f4f06edf05a1687bf755af27b upstream.

While it might work, the current approach is fragile in a few ways:
- whenever members in the structure are shuffled, the pointer will be wrong
- the resource freeing may include more than covered by kfree()

Fix this by using charlcd_free() call instead of kfree().

Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/auxdisplay/lcd2s.c