]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
scsi: bnx2fc: Fix check in SCSI completion handler for timed out request
authorChad Dupuis <chad.dupuis@cavium.com>
Wed, 24 Jan 2018 16:07:06 +0000 (08:07 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 31 Jan 2018 02:27:02 +0000 (21:27 -0500)
commitecf7ff49945f5741fa1da112f994939f942031d3
tree85156dc9b7a4cc33d5c58247ba1cacdf8b24b289
parent52797a1d4b39716ddd300a3c463ffaf1330600a0
scsi: bnx2fc: Fix check in SCSI completion handler for timed out request

When a request times out we set the io_req flag BNX2FC_FLAG_IO_COMPL so
that if a subsequent completion comes in on that task ID we will ignore
it.  The issue is that in the check for this flag there is a missing
return so we will continue to process a request which may have already
been returned to the ownership of the SCSI layer.  This can cause
unpredictable results.

Solution is to add in the missing return.

[mkp: typo plus title shortening]

Signed-off-by: Chad Dupuis <chad.dupuis@cavium.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Tested-by: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/bnx2fc/bnx2fc_io.c