]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
sched/topology: Restore SD_PREFER_SIBLING on MC domains
authorPeter Zijlstra <peterz@infradead.org>
Mon, 2 Oct 2017 12:50:33 +0000 (14:50 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 10 Oct 2017 09:45:27 +0000 (11:45 +0200)
commited4ad1ca08a53cf1a805478678d1e7ff0d2cf251
treedf07167f99faa528b598d522cf023e8c7a699d8e
parent799ba82de01e7543f6b2042e1a739f3a20255f23
sched/topology: Restore SD_PREFER_SIBLING on MC domains

The normal x86_topology on NHM+ machines degenerates because the MC
and CPU domains are of the same size, therefore MC inherits
SD_PREFER_SIBLING from CPU (which then gets taken out). The result is
that we'll spread tasks across the first NUMA level in order to
maximize cache utilization.

However, for the x86_numa_in_package_topology we loose the CPU domain,
and we'll not have SD_PREFER_SIBLING set anywhere, giving a distinct
difference in behaviour.

Commit:

  8e7fbcbc22c1 ("sched: Remove stale power aware scheduling remnants and dysfunctional knobs")

made a fail by not preserving the SD_PREFER_SIBLING for the !power_saving
case on both CPU and MC.

Then commit:

  6956dc568f34 ("sched/numa: Add SD_PERFER_SIBLING to CPU domain")

adds it back to the CPU but not MC.

Restore that now, such that we get consistent spreading behaviour wrt
L3 and NUMA.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/topology.c