]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
tracing: Fix fields of struct trace_iterator that are zeroed by mistake
authorAndrew Vagin <avagin@openvz.org>
Fri, 2 Aug 2013 17:16:43 +0000 (21:16 +0400)
committerSteven Rostedt <rostedt@goodmis.org>
Sat, 3 Aug 2013 02:28:41 +0000 (22:28 -0400)
commited5467da0e369e65b247b99eb6403cb79172bcda
treea7a281193d68cc8e24660657e4f127dfb4acd555
parentc6c2401d8bbaf9edc189b4c35a8cb2780b8b988e
tracing: Fix fields of struct trace_iterator that are zeroed by mistake

tracing_read_pipe zeros all fields bellow "seq". The declaration contains
a comment about that, but it doesn't help.

The first field is "snapshot", it's true when current open file is
snapshot. Looks obvious, that it should not be zeroed.

The second field is "started". It was converted from cpumask_t to
cpumask_var_t (v2.6.28-4983-g4462344), in other words it was
converted from cpumask to pointer on cpumask.

Currently the reference on "started" memory is lost after the first read
from tracing_read_pipe and a proper object will never be freed.

The "started" is never dereferenced for trace_pipe, because trace_pipe
can't have the TRACE_FILE_ANNOTATE options.

Link: http://lkml.kernel.org/r/1375463803-3085183-1-git-send-email-avagin@openvz.org
Cc: stable@vger.kernel.org # 2.6.30
Signed-off-by: Andrew Vagin <avagin@openvz.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
include/linux/ftrace_event.h
kernel/trace/trace.c