]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ethoc: fix null dereference in ethoc_probe
authorThomas Chou <thomas@wytron.com.tw>
Sun, 23 May 2010 16:44:02 +0000 (16:44 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 May 2010 06:11:09 +0000 (23:11 -0700)
commitee02a4ef40f2e049c80f9cc04e21a9b48288b6ff
tree26a6accadf8b370425b7c7c5e15351375a1fbf10
parent253683bbfb6bc5864417c8c35cb6ef13b5e259e6
ethoc: fix null dereference in ethoc_probe

Dan reported the patch 0baa080c75c: "ethoc: use system memory
as buffer" introduced a potential null dereference.

  1060  free:
  1061          if (priv->dma_alloc)
                    ^^^^^^^^^^^^^^^
priv can be null here.

He also suggested that the error handling is not complete.

This patch fixes the null priv issue and improves resources
releasing in ethoc_probe() and ethoc_remove().

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethoc.c