]> git.proxmox.com Git - mirror_qemu.git/commit
qdev-monitor: Unref device when device_add fails
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 10 Sep 2013 16:21:08 +0000 (18:21 +0200)
committerAndreas Färber <afaerber@suse.de>
Tue, 5 Nov 2013 17:06:24 +0000 (18:06 +0100)
commitee6abeb6ec08473713848ce9028110f1684853b7
tree5fc29c54230425e4a26d9723dadd48f4c89b18bc
parent2fa4e56d88aa0039062bbc7f9a88e9f90c77ed94
qdev-monitor: Unref device when device_add fails

qdev_device_add() leaks the created device upon failure.  I suspect this
problem crept in because qdev_free() unparents the device but does not
drop a reference - confusing name.

Cc: qemu-stable@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
qdev-monitor.c