]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
netfilter: nfnetlink: nfnetlink_unicast() reports EAGAIN instead of ENOBUFS
authorPablo Neira Ayuso <pablo@netfilter.org>
Sun, 23 Aug 2020 11:55:36 +0000 (13:55 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 28 Aug 2020 18:11:58 +0000 (20:11 +0200)
commitee921183557af39c1a0475f982d43b0fcac25e2e
treee7817a4e5386a6af0311fd747a5c89becb4b34b2
parent4b7ddc58e61ada82be1f47f82d5139f0ab2ba478
netfilter: nfnetlink: nfnetlink_unicast() reports EAGAIN instead of ENOBUFS

Frontend callback reports EAGAIN to nfnetlink to retry a command, this
is used to signal that module autoloading is required. Unfortunately,
nlmsg_unicast() reports EAGAIN in case the receiver socket buffer gets
full, so it enters a busy-loop.

This patch updates nfnetlink_unicast() to turn EAGAIN into ENOBUFS and
to use nlmsg_unicast(). Remove the flags field in nfnetlink_unicast()
since this is always MSG_DONTWAIT in the existing code which is exactly
what nlmsg_unicast() passes to netlink_unicast() as parameter.

Fixes: 96518518cc41 ("netfilter: add nftables")
Reported-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/linux/netfilter/nfnetlink.h
net/netfilter/nf_tables_api.c
net/netfilter/nfnetlink.c
net/netfilter/nfnetlink_log.c
net/netfilter/nfnetlink_queue.c