]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
io_uring: don't block level reissue off completion path
authorJens Axboe <axboe@kernel.dk>
Tue, 27 Jul 2021 16:50:31 +0000 (10:50 -0600)
committerJens Axboe <axboe@kernel.dk>
Wed, 28 Jul 2021 13:24:38 +0000 (07:24 -0600)
commitef04688871f3386b6d40ade8f5c664290420f819
tree1ae872efba193225d4d350cee41c8a2524001c75
parent773af69121ecc6c53d192661af8d53bb3db028ae
io_uring: don't block level reissue off completion path

Some setups, like SCSI, can throw spurious -EAGAIN off the softirq
completion path. Normally we expect this to happen inline as part
of submission, but apparently SCSI has a weird corner case where it
can happen as part of normal completions.

This should be solved by having the -EAGAIN bubble back up the stack
as part of submission, but previous attempts at this failed and we're
not just quite there yet. Instead we currently use REQ_F_REISSUE to
handle this case.

For now, catch it in io_rw_should_reissue() and prevent a reissue
from a bogus path.

Cc: stable@vger.kernel.org
Reported-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c