]> git.proxmox.com Git - mirror_qemu.git/commit
sockets: Bypass "replace empty @path" for abstract unix sockets
authorMarkus Armbruster <armbru@redhat.com>
Mon, 2 Nov 2020 09:44:21 +0000 (10:44 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 3 Nov 2020 13:17:12 +0000 (13:17 +0000)
commitef298e3826e574c712d10e38a5f2a3629d6f5e01
tree181faeb522cbcbc6fedc7b534c0133114e85e723
parentdea7cd1794f33c52e4b59fe085daffb318a4bb07
sockets: Bypass "replace empty @path" for abstract unix sockets

unix_listen_saddr() replaces empty @path by unique value.  It obtains
the value by creating and deleting a unique temporary file with
mkstemp().  This is racy, as the comment explains.  It's also entirely
undocumented as far as I can tell.  Goes back to commit d247d25f18
"sockets: helper functions for qemu (Gerd Hoffman)", v0.10.0.

Since abstract socket addresses have no connection with filesystem
pathnames, making them up with mkstemp() seems inappropriate.  Bypass
the replacement of empty @path.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
util/qemu-sockets.c