]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bridge: Fix potential deadlock on br->multicast_lock
authorAndrey Vagin <avagin@openvz.org>
Thu, 10 Nov 2011 05:48:03 +0000 (05:48 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Nov 2011 05:38:53 +0000 (00:38 -0500)
commitef5e0d8237287db3a12d84f08fb2483d7a30a943
tree788e6c6546b4e3af7b01e0863ef4f2d8808e50ef
parent731abb9cb27aef6013ce60808a04e04a545f3f4e
bridge: Fix potential deadlock on br->multicast_lock

multicast_lock is taken in softirq context, so we should use
spin_lock_bh() in userspace.

call-chain in softirq context:
run_timer_softirq()
br_multicast_query_expired()

call-chain in userspace:
sysfs_write_file()
store_multicast_snooping()
br_multicast_toggle()

Signed-off-by: Andrew Vagin <avagin@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_multicast.c