]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
netfilter: ctnetlink: fix error return code in init path
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 29 Aug 2012 06:49:16 +0000 (06:49 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 30 Aug 2012 01:28:22 +0000 (03:28 +0200)
commitef6acf68c259d907517dcc0ffefcd4e30276ae29
tree0742883dc0de77d7b49fa0fb866206519f362e14
parent0a54e939d8c2647c711ef2369c3e73c3b7f3028c
netfilter: ctnetlink: fix error return code in init path

Initialize return variable before exiting on an error path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_netlink.c