]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: rme9652: Hardening for potential Spectre v1
authorTakashi Iwai <tiwai@suse.de>
Tue, 24 Apr 2018 06:04:41 +0000 (08:04 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 14 Aug 2018 10:24:02 +0000 (12:24 +0200)
commitef6e01a6d1d799ac1e30ab3442e762a197339709
treeb1ac9a84683a2958001d309647010b172f5bcddc
parent5d588920fc4b161f9dc56f0f2717c10b3ee7d7cd
ALSA: rme9652: Hardening for potential Spectre v1

BugLink: http://bugs.launchpad.net/bugs/1778265
commit f526afcd8f71945c23ce581d7864ace93de8a4f7 upstream.

As recently Smatch suggested, one place in RME9652 driver may expand
the array directly from the user-space value with speculation:
  sound/pci/rme9652/rme9652.c:2074 snd_rme9652_channel_info() warn: potential spectre issue 'rme9652->channel_map' (local cap)

This patch puts array_index_nospec() for hardening against it.

BugLink: https://marc.info/?l=linux-kernel&m=152411496503418&w=2
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/pci/rme9652/rme9652.c