]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: sched: don't expose action qstats to skb_tc_reinsert()
authorVlad Buslov <vladbu@mellanox.com>
Wed, 30 Oct 2019 14:09:03 +0000 (16:09 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 31 Oct 2019 01:07:50 +0000 (18:07 -0700)
commitef816f3c49c1c404ababc50e10d4cbe5109da678
treef9caa7727948d1b465e9e47041bfd2cb82586b40
parent26b537a88ca5b7399c7ab0656e06dbd9da9513c1
net: sched: don't expose action qstats to skb_tc_reinsert()

Previous commit introduced helper function for updating qstats and
refactored set of actions to use the helpers, instead of modifying qstats
directly. However, one of the affected action exposes its qstats to
skb_tc_reinsert(), which then modifies it.

Refactor skb_tc_reinsert() to return integer error code and don't increment
overlimit qstats in case of error, and use the returned error code in
tcf_mirred_act() to manually increment the overlimit counter with new
helper function.

Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sch_generic.h
net/sched/act_mirred.c