]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
fbdev: Use screen_buffer in fb_sys_{read,write}()
authorThomas Zimmermann <tzimmermann@suse.de>
Fri, 28 Apr 2023 12:24:48 +0000 (14:24 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 8 May 2023 13:28:33 +0000 (15:28 +0200)
commitf06875dc4c4f5d8895519857e441d407e88280e4
tree5bd254c9bf0c40fcb70b00c96e4c0a5de916960a
parent921b7383f34802726a7f45b6b38ef62bae0df4d6
fbdev: Use screen_buffer in fb_sys_{read,write}()

Use info->screen_buffer when reading and writing framebuffers in
system memory. It's the correct pointer for this address space.

The struct fb_info has a union to store the framebuffer memory. This can
either be info->screen_base if the framebuffer is stored in I/O memory,
or info->screen_buffer if the framebuffer is stored in system memory.

Since the fb_sys_{read,write}() functions operate on the latter address
space, it is wrong to use .screen_base and .screen_buffer must be used
instead. This also gets rid of all the casting needed due to not using
the correct data type.

v2:
* add detailed commit message (Javier)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Sui Jingfeng <suijingfeng@loongson.cn>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230428122452.4856-16-tzimmermann@suse.de
drivers/video/fbdev/core/fb_sys_fops.c