]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
bridge: reduce size of input cb to 16 bytes
authorFlorian Westphal <fw@strlen.de>
Thu, 11 Apr 2019 14:36:40 +0000 (16:36 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 11 Apr 2019 23:47:27 +0000 (01:47 +0200)
commitf12064d1b402c60c5db9c4b63d5ed6d7facb33f6
tree3baf5120d728d59d10ad1cfb51daa1fed4ba42e6
parent26f7fe4a5db5b41d2abe53e37100c8984b157fb2
bridge: reduce size of input cb to 16 bytes

Reduce size of br_input_skb_cb from 24 to 16 bytes by
using bitfield for those values that can only be 0 or 1.

igmp is the igmp type value, so it needs to be at least u8.

Furthermore, the bridge currently relies on step-by-step initialization
of br_input_skb_cb fields as the skb passes through the stack.

Explicitly zero out the bridge input cb instead, this avoids having to
review/validate that no BR_INPUT_SKB_CB(skb)->foo test can see a
'random' value from previous protocol cb.

AFAICS all current fields are always set up before they are read again,
so this is not a bug fix.

Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/bridge/br_arp_nd_proxy.c
net/bridge/br_input.c
net/bridge/br_private.h