]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
regulator: ltc3589: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 15:35:35 +0000 (15:35 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:11:55 +0000 (15:11 +0000)
commitf132da2534ec6599c78c4adcef15340cff2e9dd9
treed9e011faaca74d8f443173417d935bbbde7662ad
parent89b2758c192c35068b07766a6830433bfbdc1f44
regulator: ltc3589: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: 3eb2c7ecb7ea ("regulator: Add LTC3589 support")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/ltc3589.c