]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
mlxsw: core: Prevent reading unsupported slave address from SFP EEPROM
authorVadim Pasternak <vadimp@mellanox.com>
Sat, 18 May 2019 15:58:29 +0000 (18:58 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 18 May 2019 20:13:40 +0000 (13:13 -0700)
commitf1436c8036fa3632b2ee78841cf5184b7ef0ad87
treebec4eeb2158d856439ff0c065d652f399375065c
parentc52ecff7e6439ca8c9b03282e8869a005aa94831
mlxsw: core: Prevent reading unsupported slave address from SFP EEPROM

Prevent reading unsupported slave address from SFP EEPROM by testing
Diagnostic Monitoring Type byte in EEPROM. Read only page zero of
EEPROM, in case this byte is zero.

If some SFP transceiver does not support Digital Optical Monitoring
(DOM), reading SFP EEPROM slave address 0x51 could return an error.
Availability of DOM support is verified by reading from zero page
Diagnostic Monitoring Type byte describing how diagnostic monitoring is
implemented by transceiver. If bit 6 of this byte is set, it indicates
that digital diagnostic monitoring has been implemented. Otherwise it is
not and transceiver could fail to reply to transaction for slave address
0x51 [1010001X (A2h)], which is used to access measurements page.

Such issue has been observed when reading cable MCP2M00-xxxx,
MCP7F00-xxxx, and few others.

Fixes: 2ea109039cd3 ("mlxsw: spectrum: Add support for access cable info via ethtool")
Fixes: 4400081b631a ("mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+")
Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core_env.c