]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
net: phy: Do not perform software reset for Generic PHY
authorFlorian Fainelli <f.fainelli@gmail.com>
Sun, 5 Mar 2017 20:34:49 +0000 (12:34 -0800)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Tue, 22 Aug 2017 09:58:01 +0000 (06:58 -0300)
commitf1641d3bb29620747a1be4ffcd43e30e47ab8f08
treecb908f22053807196897094693a4abcc273d1638
parent948e5e54b0b4840fe608da2dc671f61abf474022
net: phy: Do not perform software reset for Generic PHY

BugLink: http://bugs.launchpad.net/bugs/1710646
commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 upstream.

The Generic PHY driver is a catch-all PHY driver and it should preserve
whatever prior initialization has been done by boot loader or firmware
agents. For specific PHY device configuration it is expected that a
specialized PHY driver would take over that role.

Resetting the generic PHY was a bad idea that has lead to several
complaints and downstream workarounds e.g: in OpenWrt/LEDE so restore
the behavior prior to 87aa9f9c61ad ("net: phy: consolidate PHY
reset in phy_init_hw()").

Reported-by: Felix Fietkau <nbd@nbd.name>
Fixes: 87aa9f9c61ad ("net: phy: consolidate PHY reset in phy_init_hw()")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/net/phy/phy_device.c
include/linux/phy.h