]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
fs/super.c: don't fool lockdep in freeze_super() and thaw_super() paths
authorOleg Nesterov <oleg@redhat.com>
Mon, 26 Sep 2016 16:55:25 +0000 (18:55 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 15 Oct 2016 00:41:59 +0000 (20:41 -0400)
commitf1a9622037cd370460fd06bb7e28d0f01ceb8ef1
tree647a7c6d70173cbb7c40237a3dcfbd81346014d8
parent89f39af129382a40d7cd1f6914617282cfeee28e
fs/super.c: don't fool lockdep in freeze_super() and thaw_super() paths

sb_wait_write()->percpu_rwsem_release() fools lockdep to avoid the
false-positives. Now that xfs was fixed by Dave's commit dbad7c993053
("xfs: stop holding ILOCK over filldir callbacks") we can remove it and
change freeze_super() and thaw_super() to run with s_writers.rw_sem locks
held; we add two trivial helpers for that, lockdep_sb_freeze_release()
and lockdep_sb_freeze_acquire().

xfstests-dev/check `grep -il freeze tests/*/???` does not trigger any
warning from lockdep.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/super.c