]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
usb: gadget: u_serial: Add null pointer check in gserial_suspend
authorPrashanth K <quic_prashk@quicinc.com>
Fri, 5 May 2023 09:18:37 +0000 (14:48 +0530)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Mon, 2 Oct 2023 15:19:55 +0000 (17:19 +0200)
commitf1b119fe31a14d19690a34b29c273c04bd62f02c
tree47299c5ae78c753171930f6f8eca713603c245b7
parent3fdd86684f58f7595e3aa8236bf8d803082112c2
usb: gadget: u_serial: Add null pointer check in gserial_suspend

BugLink: https://bugs.launchpad.net/bugs/2034469
[ Upstream commit 2f6ecb89fe8feb2b60a53325b0eeb9866d88909a ]

Consider a case where gserial_disconnect has already cleared
gser->ioport. And if gserial_suspend gets called afterwards,
it will lead to accessing of gser->ioport and thus causing
null pointer dereference.

Avoid this by adding a null pointer check. Added a static
spinlock to prevent gser->ioport from becoming null after
the newly added null pointer check.

Fixes: aba3a8d01d62 ("usb: gadget: u_serial: add suspend resume callbacks")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
Link: https://lore.kernel.org/r/1683278317-11774-1-git-send-email-quic_prashk@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/usb/gadget/function/u_serial.c