]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
USB: usbmon: fix read(2)
authorPete Zaitcev <zaitcev@redhat.com>
Fri, 14 Nov 2008 16:47:41 +0000 (09:47 -0700)
committerGreg Kroah-Hartman <gregkh@kvm.kroah.org>
Thu, 20 Nov 2008 06:01:35 +0000 (22:01 -0800)
commitf1c0a2a3aff53698f4855968d576464041d49b39
treee5b247b91ce77706a1d1cdb3b7421bca6a295c32
parentff3495052af48f7a2bf7961b131dc9e161dae19c
USB: usbmon: fix read(2)

There's a bug in the usbmon binary reader: When using read() to fetch
the packets and a packet's data is partially read, the next read call
will once again return up to len_cap bytes of data. The b_read counter
is not regarded when determining the remaining chunk size.

So, when dumping USB data with "cat /dev/usbmon0 > usbmon.trace" while
reading from a USB storage device and analyzing the dump file
afterwards it will get out of sync after a couple of packets.

Signed-off-by: Ingo van Lil <inguin@gmx.de>
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/mon/mon_bin.c