]> git.proxmox.com Git - mirror_qemu.git/commit
MIPS: Correct FCR0 initialization
authorNathan Froyd <froydnj@codesourcery.com>
Thu, 7 Jun 2012 15:04:14 +0000 (15:04 +0000)
committerBlue Swirl <blauwirbel@gmail.com>
Thu, 9 Aug 2012 18:36:19 +0000 (18:36 +0000)
commitf1cb0951c5298753652a73cfd8efc0b1a82f37de
tree49b9bbe429139f35dd405a554354f53e9c1d5453
parent832a226b62c6bf75c57ec3ae4d6964923d2aabcd
MIPS: Correct FCR0 initialization

 This change addresses a problem where QEMU incorrectly traps on
floating-point MADD group instructions with SIGILL, at least while
emulating MIPS32r2 processors.  These instructions use the COP1X major
opcode and include ones like:

madd.d $f2,$f4,$f2,$f6

 Here's Nathan's original analysis of the problem:

"QEMU essentially does:

  d = find_cpu (cpu_string) // get CPU definition
  fpu_init (env, d) // initialize fpu state (init FCR0, basically)
  cpu_reset (env)

...and the cpu_reset call clears all interesting state that fpu_init
setup, then proceeds to reinitialize all the CP0 registers...but not
FCR0."

 I have verified this change with system emulation running the GDB test
suite for the mips-sde-elf target (o32, big endian, 24Kf CPU emulated),
there were 55 progressions and no regressions.

Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
target-mips/translate.c