]> git.proxmox.com Git - mirror_qemu.git/commit
accel/tcg: Fix sense of read-only probes in ldst_atomicity
authorRichard Henderson <richard.henderson@linaro.org>
Sat, 22 Jul 2023 10:23:06 +0000 (11:23 +0100)
committerRichard Henderson <richard.henderson@linaro.org>
Sun, 23 Jul 2023 16:57:10 +0000 (17:57 +0100)
commitf1ce0b80283e19d5e65a5c2b0b4de6d92ca7f527
treeb763af007c1a1146f3a9a6002943221b38de5298
parent990ef9182b5b7cb63be8da918fe38865b3ab840a
accel/tcg: Fix sense of read-only probes in ldst_atomicity

In the initial commit, cdfac37be0d, the sense of the test is incorrect,
as the -1/0 return was confusing.  In bef6f008b981, we mechanically
invert all callers while changing to false/true return, preserving the
incorrectness of the test.

Now that the return sense is sane, it's easy to see that if !write,
then the page is not modifiable (i.e. most likely read-only, with
PROT_NONE handled via SIGSEGV).

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
accel/tcg/ldst_atomicity.c.inc