]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
vfs: move permission checking into notify_change() for utimes(NULL)
authorMiklos Szeredi <mszeredi@redhat.com>
Fri, 16 Sep 2016 10:44:20 +0000 (12:44 +0200)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 8 Nov 2016 16:44:52 +0000 (16:44 +0000)
commitf1e96ec9007adf569f225b80dde56e97529bdcd5
treee4b69fd5739befeac419d7fa87b1633ffbe50150
parent1c982a1f28911b49fa2566078b69fba38049f942
vfs: move permission checking into notify_change() for utimes(NULL)

BugLink: http://bugs.launchpad.net/bugs/1637501
commit f2b20f6ee842313a0d681dbbf7f87b70291a6a3b upstream.

This fixes a bug where the permission was not properly checked in
overlayfs.  The testcase is ltp/utimensat01.

It is also cleaner and safer to do the permission checking in the vfs
helper instead of the caller.

This patch introduces an additional ia_valid flag ATTR_TOUCH (since
touch(1) is the most obvious user of utimes(NULL)) that is passed into
notify_change whenever the conditions for this special permission checking
mode are met.

Reported-by: Aihua Zhang <zhangaihua1@huawei.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Tested-by: Aihua Zhang <zhangaihua1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
fs/attr.c
fs/utimes.c
include/linux/fs.h